Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-adaptive thresholding bug #152

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

djdameln
Copy link
Contributor

Description

  • Uses the default threshold values specified by the user when creating the F1 metrics. This makes sure that when adaptive thresholding is disabled, and no normalization is used, the F1 computation will be based on the user-specified threshold.

  • Adds a test case that checks if the thresholds get assigned correctly in the above conditions.

  • Fixes Threshold values are ignored when using non adaptive threshold #139

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay merged commit b66e5e3 into development Mar 22, 2022
@samet-akcay samet-akcay deleted the fix/da/non-adaptive-thresholding branch March 22, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threshold values are ignored when using non adaptive threshold
2 participants