Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate feature map shape patchcore #148

Merged
merged 9 commits into from
Mar 22, 2022
Merged

Calculate feature map shape patchcore #148

merged 9 commits into from
Mar 22, 2022

Conversation

alexriedel1
Copy link
Contributor

Fixing #40

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexriedel1! I spotted one small mistake. Other than that the PR looks fine and it's a great addition.

anomalib/models/patchcore/model.py Show resolved Hide resolved
@djdameln
Copy link
Contributor

There seem to be some code quality issues, see logs here. Did you use pre-commit?

@alexriedel1
Copy link
Contributor Author

There seem to be some code quality issues, see logs here. Did you use pre-commit?

now I did :)

@samet-akcay
Copy link
Contributor

@alexriedel1, I'll run the CI now. We could merge as soon as the tests pass

@alexriedel1
Copy link
Contributor Author

@alexriedel1, I'll run the CI now. We could merge as soon as the tests pass

ahh sorry I didn't commit after the formatting changes were made, gonna fix it

@samet-akcay
Copy link
Contributor

samet-akcay commented Mar 18, 2022

Checks complain about some formatting issues. If you could run black -l 120 anomalib from the main root directory, black should be able to format the file, and the CI would pass. Apologies for this bureaucracy, but this is needed for the maintanence.

@alexriedel1
Copy link
Contributor Author

Checks complain about some formatting issues. If you could run black -l 120 anomalib from the main root directory, black should be able to format the file, and the CI would pass. Apologies for this bureaucracy, but this is needed for the maintanence.

Sorry for making this such a mess :D

@samet-akcay
Copy link
Contributor

Sorry for making this such a mess :D

No problem at all! Thanks a lot for the contribution!

@samet-akcay samet-akcay merged commit b57e025 into openvinotoolkit:development Mar 22, 2022
@alexriedel1 alexriedel1 deleted the patchcore/featuremapshape branch March 24, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants