Enable multi-gpu AnomalyScoreThreshold #1413
Open
+4
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
compute
is not supposed to update state variables, in this casevalue
, as defined byself.add_state("value", default=torch.tensor(default_value), persistent=True)
. The current implementation doesn't cause problems until you use multiple GPUs, where any changes toself.value
incompute
are discarded. Updating the variable is supposed to happen inupdate()
or outside of the class. I elected to do it outside of the class.Given how awkward this was to figure out and the hacky fix required, maybe
AnomalyScoreThreshold
shouldn't sub-class what its currently sub-classing?Checklist
Ensure that you followed the following