Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/da/image size bug #140

Merged
merged 8 commits into from
Mar 9, 2022
Merged

Fix/da/image size bug #140

merged 8 commits into from
Mar 9, 2022

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Mar 9, 2022

Description

  • Fix bug in inference when the input image is non-square. This was caused by difference between torch and cv2 in height/width dim ordering.

  • Fixes Resize bug in inference #83

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@djdameln djdameln mentioned this pull request Mar 9, 2022
@samet-akcay samet-akcay merged commit 8457809 into development Mar 9, 2022
@samet-akcay samet-akcay deleted the fix/da/image_size_bug branch March 9, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resize bug in inference
2 participants