Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/data/btad #120

Merged
merged 16 commits into from
Mar 15, 2022
Merged

Feature/data/btad #120

merged 16 commits into from
Mar 15, 2022

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Feb 25, 2022

Description

  • This PR adds BTec dataset into the repo and refactors MVTec

Note

It's important to note that furter refactoring could be possible to abstract, but this would be done after all the datasets of interest are added to the repo.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I only have one minor comment.

+ "/ground_truth/"
+ samples.label
+ "/"
+ samples.image_path.str.rstrip("bmp").str.rstrip(".")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use with_suffix here?

Copy link
Contributor Author

@samet-akcay samet-akcay Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could try, but probably wouldn't work. It's becuse this line changes the entire column. And, as far as I know, only str manipulation is possible with this approch.

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 539ee6b into development Mar 15, 2022
@samet-akcay samet-akcay deleted the feature/data/btad branch March 15, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants