Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FPS counter to TimerCallback #12

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

ashwinvaidya17
Copy link
Collaborator

  • Fix docs strings
  • Add frames per second calculation to timer.py

- Fix docs strings
- Add frames per second calculation to `timer.py`
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only minor comment

def on_fit_end(self, trainer: Trainer, pl_module: LightningModule) -> None: # pylint: disable=W0613
"""Call when fit ends.

Prints the time taken for trining.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@djdameln
Copy link
Contributor

djdameln commented Dec 2, 2021

Thanks, looks good to me

@samet-akcay samet-akcay merged commit cf8bdf6 into development Dec 3, 2021
@samet-akcay samet-akcay deleted the feature/ashwin/fps_counter branch December 3, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants