Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Add tests for tools #1069

Merged
merged 8 commits into from
May 12, 2023
Merged

🧪 Add tests for tools #1069

merged 8 commits into from
May 12, 2023

Conversation

ashwinvaidya17
Copy link
Collaborator

Changes

  • Add tests

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@github-actions github-actions bot added Inference Tests Tools Dependencies Pull requests that update a dependency file labels May 3, 2023
samet-akcay
samet-akcay requested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just few comments.

tests/pre_merge/tools/test_gradio_entrypoint.py Outdated Show resolved Hide resolved
tests/pre_merge/tools/test_torch_entrypoint.py Outdated Show resolved Hide resolved
tools/inference/lightning_inference.py Show resolved Hide resolved
tests/pre_merge/tools/conftest.py Show resolved Hide resolved
@samet-akcay samet-akcay removed Dependencies Pull requests that update a dependency file Setup Inference labels May 5, 2023
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file Inference Setup labels May 8, 2023
samet-akcay
samet-akcay approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks a lot!

djdameln
djdameln approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@ashwinvaidya17 ashwinvaidya17 merged commit a589394 into openvinotoolkit:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln djdameln approved these changes

@yunchu yunchu Awaiting requested review from yunchu

Assignees
No one assigned
Labels
CI Dependencies Pull requests that update a dependency file Inference Setup Tests Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashwinvaidya17 @samet-akcay @djdameln