🚚 Thresholding refactor #1064
Closed
🚚 Thresholding refactor #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
samet-akcay
requested changes
May 5, 2023
There was a problem hiding this comment.
Thanks @ashwinvaidya17. Looking good to me.
A question though. Can we make it backward compatible? up until v1, I feel we should support backward compatibility. Otherwise, we'll break this again, which would be annoying.
Would it be possible to check threshold in config? For example, if there is method key we could instantiate AdaptiveScoreThreshold under the hood, no?
Comment on lines
+142
to
+143
| image_threshold_class = image_threshold_config.get("class_path", None) if image_threshold_config else None | ||
| image_threshold_args = image_threshold_config.get("init_args", None) if image_threshold_config else None |
There was a problem hiding this comment.
This would be a bit more verbose, but more accurate?
Suggested change
| image_threshold_class = image_threshold_config.get("class_path", None) if image_threshold_config else None | |
| image_threshold_args = image_threshold_config.get("init_args", None) if image_threshold_config else None | |
| image_threshold_class_path = image_threshold_config.get("class_path", None) if image_threshold_config else None | |
| image_threshold_init_args = image_threshold_config.get("init_args", None) if image_threshold_config else None |
Comment on lines
+145
to
+146
| pixel_threshold_class = pixel_threshold_config.get("class_path", None) if pixel_threshold_config else None | ||
| pixel_threshold_args = pixel_threshold_config.get("init_args", None) if pixel_threshold_config else None |
| raise NotImplementedError("Subclass of BaseAnomalyScoreThreshold must implement the update method") | ||
|
|
||
| def state_dict( | ||
| self, destination: Dict[str, Any], prefix: str = "", keep_vars: bool = False |
There was a problem hiding this comment.
Suggested change
| self, destination: Dict[str, Any], prefix: str = "", keep_vars: bool = False | |
| self, destination: dict[str, Any], prefix: str = "", keep_vars: bool = False |
|
|
||
| def state_dict( | ||
| self, destination: Dict[str, Any], prefix: str = "", keep_vars: bool = False | ||
| ) -> Dict[str, Any] | None: |
There was a problem hiding this comment.
Suggested change
| ) -> Dict[str, Any] | None: | |
| ) -> dict[str, Any] | None: |
| from __future__ import annotations | ||
|
|
||
| from abc import ABC | ||
| from typing import Any, Dict |
There was a problem hiding this comment.
Suggested change
| from typing import Any, Dict | |
| from typing import Any |
|
Closing as these changes are mirrored in a PR to custom loops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Checklist