Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug: 839] Crop in SSPCAB implementation #1057

Merged
merged 4 commits into from
Apr 28, 2023
Merged

[Bug: 839] Crop in SSPCAB implementation #1057

merged 4 commits into from
Apr 28, 2023

Conversation

isaacncz
Copy link
Contributor

@isaacncz isaacncz commented Apr 28, 2023 •
edited
Loading

Description

This fix follows the official implementation for the SSPCAB by the original author

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

[Bug: 839] Crop in SSPCAB implementation
a08af4e 
This fix follows the official implementation for the SSPCAB by the original author

Fixes openvinotoolkit#839

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>
@isaacncz isaacncz requested a review from djdameln as a code owner April 28, 2023 01:17
Ng, Che Zhek added 3 commits April 28, 2023 09:33
remove trailing whitespace
5147bca
[Bug: 839] Crop in SSPCAB implementation
4f5c2b1 
This fix follows the official implementation for the SSPCAB by the original author

Fixes openvinotoolkit#839

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>

remove trailing whitespace
Merge branch 'bug-839-dev' of https://github.com/isaacncz/anomalib in…
622c3d4 
…to bug-839-dev
@ashwinvaidya17 ashwinvaidya17 self-requested a review April 28, 2023 08:10
@samet-akcay samet-akcay enabled auto-merge (squash) April 28, 2023 08:16
samet-akcay
samet-akcay approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit eadb75a into openvinotoolkit:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln Awaiting requested review from djdameln djdameln is a code owner

@ashwinvaidya17 ashwinvaidya17 Awaiting requested review from ashwinvaidya17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Crop in SSPCAB implementation
2 participants
@isaacncz @samet-akcay