Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Algo] Attribute-based Representations for Accurate and Interpretable Video Anomaly Detection #1040

Merged
merged 62 commits into from
May 9, 2023

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Apr 25, 2023

Description

Example predictions:
150
101
141
061

Known Issues:

  • GMM module uses numpy and sklearn for now. This needs to be replaced by a custom PyTorch implementation in the future.
  • The original implementation applies several post-processing operations to the bounding box predictions of the region extractor, which are not described in the paper. These operations are currently missing in my implementation.
  • Gaussian temporal smoothing of the predictions is missing. This will need to be addressed separately, because it will involve some design (we could design this in a generic way so that it could be re-used for all spatio-temporal video anomaly models.)
  • There is no PyPI package for CLIP, so I included the source code, which is released under MIT license.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@ashwinvaidya17 ashwinvaidya17 self-requested a review April 26, 2023 13:13
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean code! I have no major comments just few related to docstrings

src/anomalib/models/ai_vad/clip/LICENSE Show resolved Hide resolved
src/anomalib/data/ucsd_ped.py Show resolved Hide resolved
src/anomalib/models/ai_vad/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts! Looks good to me

import os
import urllib
import warnings
from typing import List, Union
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use the new format or this one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should treat everything under clip as third-party.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, i'll remove my other comments as well

@@ -59,7 +59,7 @@ project:
path: ./results

logging:
logger: [] # options: [comet, tensorboard, wandb, csv] or combinations.
logger: [wandb] # options: [comet, tensorboard, wandb, csv] or combinations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope :)

@samet-akcay samet-akcay merged commit 1bd70af into openvinotoolkit:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants