[Custom loops PoC] Extend compatibility to tests #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 3, 2023 16:22
Note: Breaks the sweep and benchmarking. This is temporary
added 7 commits
May 2, 2023 17:01
samet-akcay
reviewed
May 22, 2023
src/anomalib/deploy/export.py
Outdated
|
|
||
|
|
||
| def get_metadata(task: TaskType, transform: dict[str, Any], model: AnomalyModule) -> dict[str, Any]: | ||
| def get_metadata(trainer: AnomalibTrainer, transform: dict[str, Any]) -> dict[str, Any]: |
There was a problem hiding this comment.
Maybe for another PR, but I was wondering if it were possible to access the transform from trainer? For example, to get the training transforms,
>>> trainer.datamodule.train_data.transform.to_dict()
{'__version__': '1.3.0', 'transform': {'__class_fullname__': 'Compose', 'p': 1.0, 'transforms': [...], 'bbox_params': None, 'keypoint_params': None, 'additional_targets': {...}}}For the test transforms:
>>> trainer.datamodule.test_data.transform.to_dict()
{'__version__': '1.3.0', 'transform': {'__class_fullname__': 'Compose', 'p': 1.0, 'transforms': [...], 'bbox_params': None, 'keypoint_params': None, 'additional_targets': {...}}}
Comment on lines
+74
to
81
| if self.threshold_method == ThresholdMethod.ADAPTIVE: | ||
| if self.trainer.image_threshold is not None: | ||
| self.trainer.image_threshold.compute() | ||
| if self.trainer.task_type in (TaskType.SEGMENTATION, TaskType.DETECTION): | ||
| self.trainer.pixel_threshold.compute() | ||
| else: | ||
| self.trainer.pixel_threshold.value = self.trainer.image_threshold.value | ||
|
|
There was a problem hiding this comment.
This part will change with the thresholding refactor, right?
ashwinvaidya17
merged commit fa8fb87
into
openvinotoolkit:feature/custom_loops
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description