[Custom Loops POC] VisualizerCallback -> Logger

[ashwinvaidya17]

Description

• Refactor visualizer callback into trainer and logger classes. CSV logger is merged into FileSystemLogger that logs images to the file system as well.

[djdameln]

Thanks, overall it looks good. My main question is related to the custom visualizer POC that I'm working on atm:

Would this design make it possible to specify a class path and init args for the visualizer class? This would be needed to support custom visualizers. A custom visualizer would override some of the methods of post_processing.visualizer.Visualizer. We would need a way of telling the trainer which visualizer to use.

Another concern I have is that this design might make it a bit more challenging to save video results, but I will try to sort this out on my side.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[ashwinvaidya17]

Thanks, overall it looks good. My main question is related to the custom visualizer POC that I'm working on atm:

Would this design make it possible to specify a class path and init args for the visualizer class? This would be needed to support custom visualizers. A custom visualizer would override some of the methods of post_processing.visualizer.Visualizer. We would need a way of telling the trainer which visualizer to use.

Another concern I have is that this design might make it a bit more challenging to save video results, but I will try to sort this out on my side.

I feel this class will undergo some changes. Maybe if even I have some understanding on how the video visualizer works then I might be able to think on something on my side

[djdameln]

Thanks, I'm happy with the changes

[samet-akcay]

Thanks, I like this connector approach