-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(building-blocks): add focus trap to building blocks #765
Merged
amy-corson-ibigroup
merged 7 commits into
opentripplanner:master
from
ibi-group:move-focus-trap-to-bb
Aug 26, 2024
Merged
feat(building-blocks): add focus trap to building blocks #765
amy-corson-ibigroup
merged 7 commits into
opentripplanner:master
from
ibi-group:move-focus-trap-to-bb
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there settings that changed that are causing the build to fail?
binh-dam-ibigroup
approved these changes
Aug 16, 2024
josh-willis-arcadis
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Housing Focus Trap Wrapper in map popup doesn't make a ton of sense and is causing circular dependencies and duplicated code.
This version of focus trap also allows for some configuration of which elements are focusable within the trap. For example, if you're creating non-standard focusable elements with
tabIndex
, those can be included.