-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Popup show company name in all map popup titles #764
Map Popup show company name in all map popup titles #764
Conversation
@daniel-heppner-ibigroup I need your help updating the snapshtos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to apply the "Car" labeling to the other languages.
@@ -5,5 +5,6 @@ otpUi: | |||
floatingBike: "Vélo flottant : {name}" | |||
floatingCar: "{company} {name}" | |||
floatingEScooter: Trottinette {name} | |||
popupTitle: "{stationNetwork, select, false {{name}} other {{stationNetwork} {name}}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If popupTitle
is going to be telegraphic style at first, does it need to be in the language files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. I've made it backwards compatible so languages can adjust when they're ready. Should we consider removing the strings from other languages?
@@ -3,7 +3,8 @@ otpUi: | |||
availableBikes: "Available bikes: {value}" | |||
availableDocks: "Available docks: {value}" | |||
floatingBike: "Free-floating bike: {name}" | |||
floatingCar: "{company} {name}" | |||
floatingCar: "Car: {name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the colon needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the colon things can get messy especially if the company name is silly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if you can add the additional story to illustrate the updated floating car case. Otherwise I am good with the changes.
@daniel-heppner-ibigroup I'm going to need you to please update the snapshots again |
It was a little confusing that there was no title in the station names. Especially when feeds had terrible station names. We resolve this. As a result we remove company name from the other strings. However, the car isn't localized, so it's kept for now. In the future we might want to get rid of that