Map Popup show company name in all map popup titles #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniel-heppner-ibigroup I need your help updating the snapshtos |
daniel-heppner-ibigroup
approved these changes
Aug 13, 2024
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
binh-dam-ibigroup
requested changes
Aug 14, 2024
| @@ -5,5 +5,6 @@ otpUi: | |||
| floatingBike: "Vélo flottant : {name}" | |||
| floatingCar: "{company} {name}" | |||
| floatingEScooter: Trottinette {name} | |||
| popupTitle: "{stationNetwork, select, false {{name}} other {{stationNetwork} {name}}}" | |||
There was a problem hiding this comment.
If popupTitle is going to be telegraphic style at first, does it need to be in the language files?
There was a problem hiding this comment.
Same as above. I've made it backwards compatible so languages can adjust when they're ready. Should we consider removing the strings from other languages?
| @@ -3,7 +3,8 @@ otpUi: | |||
| availableBikes: "Available bikes: {value}" | |||
| availableDocks: "Available docks: {value}" | |||
| floatingBike: "Free-floating bike: {name}" | |||
| floatingCar: "{company} {name}" | |||
| floatingCar: "Car: {name}" | |||
There was a problem hiding this comment.
Is the colon needed?
There was a problem hiding this comment.
Without the colon things can get messy especially if the company name is silly
binh-dam-ibigroup
approved these changes
Aug 20, 2024
|
@daniel-heppner-ibigroup I'm going to need you to please update the snapshots again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a little confusing that there was no title in the station names. Especially when feeds had terrible station names. We resolve this. As a result we remove company name from the other strings. However, the car isn't localized, so it's kept for now. In the future we might want to get rid of that