-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Alert Component #744
base: master
Are you sure you want to change the base?
Create Alert Component #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! The only blocking thing for me is the huge yarn.lock
size increase
Icon?: any; | ||
} | ||
|
||
const AlertContainer = styled.div<{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider going more semantic and using a details tag?
{alerts.map((alert, i) => { | ||
return ( | ||
<> | ||
<div key={alert.alertDescriptionText}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's maybe just use the counter/UUID. Using a huge body might be funky
backgroundColor?: string; | ||
collapsable?: boolean; | ||
children?: ReactChild; | ||
Icon?: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be a JSX.Element
or something right?
"gitHead": "0af1b7cda60bd4252b219dcf893e01c2acb2ed5d" | ||
"gitHead": "0af1b7cda60bd4252b219dcf893e01c2acb2ed5d", | ||
"dependencies": { | ||
"styled-icons": "^10.47.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing a huge yarn.lock
increase. We should probably only depend on the one icon set we need
Creates a basic customizable alert in building blocks