Wcag color a11y tool #683
Open
Wcag color a11y tool #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,7 @@ | |||
| "module": "esm/index.js", | |||
| "private": false, | |||
| "dependencies": { | |||
| "color-contrast": "^1.0.0", | |||
There was a problem hiding this comment.
There are already some methods in core-utils that do this! No need for an extra library
miles-grant-ibigroup
requested changes
Dec 21, 2023
| const [foregroundError, setForegroundError] = useState(false); | ||
| const [backgroundError, setBackgroundError] = useState(false); | ||
|
|
||
| const REX_EXP = /(^#[0-9A-F]{6}$)/i; |
There was a problem hiding this comment.
Oh my god
can we at least name this HEX_REGEXP?
Comment on lines
+109
to
+111
| let hexcode = code; | ||
| if (!code.startsWith("#")) hexcode = `#${code}`; | ||
| return REX_EXP.test(hexcode); |
There was a problem hiding this comment.
Could this not be cleaner as
Suggested change
| let hexcode = code; | |
| if (!code.startsWith("#")) hexcode = `#${code}`; | |
| return REX_EXP.test(hexcode); | |
| return REX_EXP.test(hexcode) || REX_EXP.test(`#${code}`); |
| }; | ||
|
|
||
| const backgroundHandleChange = event => { | ||
| const value = event.target.value; |
There was a problem hiding this comment.
Could this be cleaner as
Suggested change
| const value = event.target.value; | |
| const { value } = event.target; |
Comment on lines
+145
to
+167
| useEffect(() => { | ||
| if (selectedColorReset) { | ||
| setSelectedColor(undefined); | ||
| } | ||
| if (!isValidHexCode(foregroundColorInput)) { | ||
| setForegroundError(true); | ||
| } else { | ||
| setForegroundError(false); | ||
| setForegroundColor(foregroundColorInput); | ||
| } | ||
| }, [foregroundColorInput]); | ||
|
|
||
| useEffect(() => { | ||
| if (selectedColorReset) { | ||
| setSelectedColor(undefined); | ||
| } | ||
| if (!isValidHexCode(backgroundColorInput)) { | ||
| setBackgroundError(true); | ||
| } else { | ||
| setBackgroundError(false); | ||
| setBackgroundColor(backgroundColorInput); | ||
| } | ||
| }, [backgroundColorInput]); |
There was a problem hiding this comment.
Why is this in here twice? Also, how is this using variables that aren't in the variable array?
|
Some of this will be fixed by #726. Let's block this until 726 is merged |
miles-grant-ibigroup
added
the
BLOCKERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a wcag color contrast tool on the color palette component.
Also, fixes an issue where story docs were getting exported to npm