Allow multiple modes selected from one checkbox #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Heppner <daniel-heppner-ibigroup@users.noreply.github.com>
Co-authored-by: Daniel Heppner <daniel.heppner@ibigroup.com>
daniel-heppner-ibigroup
requested changes
Nov 16, 2023
There was a problem hiding this comment.
This is good, although we don't urgently need this for anything, it would be nice to have it merged in. I realized that the types package change needs to be put into its own PR so that we can get a new stable version of it.
You can cherry pick that commit out to its own branch and open a PR for it.
|
@daniel-heppner-ibigroup are you ok to handle this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows multiple modes to be selected in one checkbox for mode selector