-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Mailables): Support Simultaneous Small and Large Print #925
(Mailables): Support Simultaneous Small and Large Print #925
Conversation
Signed-off-by: miles-grant-ibigroup <miles.grant@ibigroup.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you get rid of the checkboxes and just have two inputs? One for small format one for large?
Having trouble understanding why you'd want to select both checkboxes without being able to control the number for each, but it it makes sense in context I trust you
} | ||
return rows | ||
}) | ||
.flat() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky, but could just change the above map
to flatMap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much cleaner thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, meant to approve! Nothing blocking
Description:
The mailables large print feature currently disables the small print on the resulting pdf. This PR corrects this, allowing for simultaneous large and small prints. Unfortunately, there is no way to change the count for the second size. Not sure how best to solve this.
PR Checklist: