Add Mapillary links in itinerary #521
Conversation
miles-grant-ibigroup
added
the
BLOCKED
miles-grant-ibigroup
removed
the
BLOCKED
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
|
|
||
| # API key to make Mapillary API calls. These are used to show street imagery. | ||
| # mapillary: | ||
| # key: <Mapillary Key> |
There was a problem hiding this comment.
I'm not seeing an API key provided from Mapillary on the dev portal. They provide a client token and a client secret, at least with the way I registered the app. What do I put in this field? Can we call this something else? Or clarify in the comment?
There was a problem hiding this comment.
I've made a clearer comment in f68f925!
There was a problem hiding this comment.
I think my only problem with this is that it's not immediately clear what I'm looking at which I click on a Mapillary link.
For example, if I click on the icon for a "Turn left onto X road", am I looking at the imagery for X road or the road I was on right before the turn? I think the current language sounds like I am going to be looking at the intersection where I need to turn, but it seems like it is showing the image from right after the turn.
Is there any way we could clarify this? Maybe that would be better put in the itinerary-body in OTP UI. Or maybe it's not that important.
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
|
Yeah I agree with you @daniel-heppner-ibigroup. Definitely a shortcoming. The original design called for highlighting the streets at a certain zoom level and allowing a click to show you the image at that location. Sadly, this doesn't seem to work very well without vector tiles. Check out opentripplanner/otp-ui#327 for more Thank you for a thoughtful review though! |
Depends on opentripplanner/otp-ui#328
Adds Mapillary key to config to make use of
itinerary-bodyupdates. Also uses the callback to render the Mapillary iframe in a popover in the map, rather than as a popup.There is a lot of auto formatter noise in this PR, apologies. The actual changes are minimal, and mostly clone the elevation popup reducers to store a Mapillary ID in redux state that is then read by a new component which renders the iframe (and could theoretically render something else)
To enable the new feature, the active config must have a
maxillary -> keyset (see example config). You can register for a free key at https://www.mapillary.com/dashboard/developers