Clarify strategies for auto-plan #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansiroky
approved these changes
Mar 23, 2021
binh-dam-ibigroup
approved these changes
Mar 23, 2021
Merged
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (in pursuit of changes for Call Taker) clarifies/defines the various strategies for replanning a trip whenever a query param change is detected in the form (AKA auto-plan). This includes a config update to autoPlan (no real breaking changes, unless an implementation had
autoPlan: trueat some point, but this was never documented).The example config shows the approach:
otp-react-redux/example-config.yml
Lines 18 to 25 in 8d500a2