-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit max old space size when build #653
fix: limit max old space size when build #653
Conversation
WalkthroughThe recent changes primarily focus on enhancing the build process of the designer demo project by updating the scripts in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- designer-demo/package.json (1 hunks)
- packages/engine-cli/src/commands/generateConfig.js (1 hunks)
- packages/engine-cli/template/designer/package.json (1 hunks)
Additional comments not posted (5)
designer-demo/package.json (2)
8-8
: Ensure the necessity of increasingmax-old-space-size
.Including
NODE_OPTIONS=--max-old-space-size=8192
in thebuild:alpha
script is a good measure to prevent memory issues during the build process. Ensure that this value is appropriate for the project's needs.
9-9
: Verify the impact ofmax-old-space-size
on production builds.Including
NODE_OPTIONS=--max-old-space-size=8192
in thebuild
script helps manage memory during production builds. Verify that this setting does not introduce any unforeseen issues in production environments.packages/engine-cli/template/designer/package.json (2)
10-10
: Ensure the necessity of increasingmax-old-space-size
.Including
NODE_OPTIONS=--max-old-space-size=8192
in thebuild:alpha
script is a good measure to prevent memory issues during the build process. Ensure that this value is appropriate for the project's needs.
11-11
: Verify the impact ofmax-old-space-size
on production builds.Including
NODE_OPTIONS=--max-old-space-size=8192
in thebuild
script helps manage memory during production builds. Verify that this setting does not introduce any unforeseen issues in production environments.packages/engine-cli/src/commands/generateConfig.js (1)
35-38
: LGTM! Dynamically settingVITE_THEME
.The change to dynamically set the
VITE_THEME
value in thebuild:alpha
script based onoptions.theme
improves flexibility and maintainability.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit