Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(configurator): add configurator docs #631

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

gene9831
Copy link
Collaborator

@gene9831 gene9831 commented Jul 5, 2024

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Documentation
    • Introduced documentation for new configurator components: CollectionConfigurator, ColorConfigurator, SelectConfigurator, SwitchConfigurator, HtmlAttributesConfigurator, HtmlTextConfigurator, JsSlotConfigurator, NumberConfigurator, SelectIconConfigurator.
    • Updated documentation for existing configurator components: CodeConfigurator, InputConfigurator, LayoutGridConfigurator, RadioGroupConfigurator, VariableConfigurator.

These changes provide detailed examples, configuration options, and properties to aid users in utilizing various configurator components effectively.

Copy link
Contributor

coderabbitai bot commented Jul 5, 2024

Walkthrough

This update introduces comprehensive documentation for various configurator components within the packages/configurator module. Each component's documentation provides summaries, usage examples, and prop details to guide developers in integrating and using these configurators effectively. No changes were made to the declarations of exported or public entities in the codebase.

Changes

Files Change Summary
.../CodeConfigurator.md, .../LayoutGridConfigurator.md, .../RadioGroupConfigurator.md, .../VariableConfigurator.md Introduced documentation with examples and props details for existing configurator components.
.../CollectionConfigurator.md, .../ColorConfigurator.md, .../SelectConfigurator.md, .../SwitchConfigurator.md, .../HtmlAttributesConfigurator.md, .../HtmlTextConfigurator.md, .../JsSlotConfigurator.md, .../NumberConfigurator.md, .../SelectIconConfigurator.md Added new documentation files for various configurator components, including visual representations and JSON configuration examples.

Poem

In the land of lines and nodes,
New docs unfold in code,
Configurators' secrets shared,
With JSON settings well-declared.
A rabbit hops with gleeful cheer,
For clarity in docs is near,
Developers, now boldly steer!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gene9831 gene9831 closed this Jul 5, 2024
@gene9831 gene9831 reopened this Jul 5, 2024
@gene9831 gene9831 changed the base branch from develop to refactor/develop July 5, 2024 09:32
@gene9831 gene9831 changed the title Docs/configurator docs docs(configurator): add configurator docs Jul 5, 2024
@gene9831 gene9831 changed the title docs(configurator): add configurator docs docs(configurator): add configurator docs phase one Jul 5, 2024
@gene9831 gene9831 changed the title docs(configurator): add configurator docs phase one docs(configurator): add configurator docs step one Jul 5, 2024
@gene9831 gene9831 marked this pull request as ready for review July 5, 2024 09:37
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0c6a248 and d32f5a1.

Files ignored due to path filters (7)
  • packages/configurator/docs/CodeConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/CodeConfiguratorDialog.png is excluded by !**/*.png
  • packages/configurator/docs/CollectionConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/ColorConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/InputConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/SelectConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/SwitchConfigurator.png is excluded by !**/*.png
Files selected for processing (6)
  • packages/configurator/docs/CodeConfigurator.md (1 hunks)
  • packages/configurator/docs/CollectionConfigurator.md (1 hunks)
  • packages/configurator/docs/ColorConfigurator.md (1 hunks)
  • packages/configurator/docs/InputConfigurator.md (1 hunks)
  • packages/configurator/docs/SelectConfigurator.md (1 hunks)
  • packages/configurator/docs/SwitchConfigurator.md (1 hunks)
Files skipped from review due to trivial changes (5)
  • packages/configurator/docs/CodeConfigurator.md
  • packages/configurator/docs/CollectionConfigurator.md
  • packages/configurator/docs/ColorConfigurator.md
  • packages/configurator/docs/SelectConfigurator.md
  • packages/configurator/docs/SwitchConfigurator.md
Additional context used
LanguageTool
packages/configurator/docs/InputConfigurator.md

[uncategorized] ~29-~29: A punctuation mark might be missing here.
Context: ... | "Array" | -- | 当值为"Array"时,会将输入框的值使用英文逗号分割,然后将属性的值设置成数组 | | rows | number ...

(AI_EN_LECTOR_MISSING_PUNCTUATION)

Additional comments not posted (3)
packages/configurator/docs/InputConfigurator.md (3)

3-5: LGTM!

The introduction is clear and concise.


7-9: LGTM!

The display example is straightforward and includes a relevant image.


11-21: LGTM!

The configuration example is clear and well-structured.

@gene9831 gene9831 changed the title docs(configurator): add configurator docs step one docs(configurator): add configurator docs Jul 9, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d32f5a1 and dea4bfa.

Files ignored due to path filters (8)
  • packages/configurator/docs/HtmlAttributesConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/HtmlTextConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/JsSlotConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/LayoutGridConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/NumberConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/RadioGroupConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/SelectIconConfigurator.png is excluded by !**/*.png
  • packages/configurator/docs/VariableConfigurator.png is excluded by !**/*.png
Files selected for processing (8)
  • packages/configurator/docs/HtmlAttributesConfigurator.md (1 hunks)
  • packages/configurator/docs/HtmlTextConfigurator.md (1 hunks)
  • packages/configurator/docs/JsSlotConfigurator.md (1 hunks)
  • packages/configurator/docs/LayoutGridConfigurator.md (1 hunks)
  • packages/configurator/docs/NumberConfigurator.md (1 hunks)
  • packages/configurator/docs/RadioGroupConfigurator.md (1 hunks)
  • packages/configurator/docs/SelectIconConfigurator.md (1 hunks)
  • packages/configurator/docs/VariableConfigurator.md (1 hunks)
Files skipped from review due to trivial changes (6)
  • packages/configurator/docs/HtmlAttributesConfigurator.md
  • packages/configurator/docs/HtmlTextConfigurator.md
  • packages/configurator/docs/JsSlotConfigurator.md
  • packages/configurator/docs/LayoutGridConfigurator.md
  • packages/configurator/docs/SelectIconConfigurator.md
  • packages/configurator/docs/VariableConfigurator.md
Additional context used
LanguageTool
packages/configurator/docs/RadioGroupConfigurator.md

[typographical] ~31-~31: Unpaired symbol: ‘'’ seems to be missing
Context: ... | 'radio | 单选组展示形式 |

(EN_UNPAIRED_QUOTES)

packages/configurator/docs/NumberConfigurator.md

[locale-violation] ~34-~34: Possible error ortogràfic. Aquesta forma verbal no es correspon amb la varietat seleccionada (central).
Context: ...oolean |false` ...

(EXIGEIX_VERBS_CENTRAL)


[typographical] ~35-~35: Símbol sense parella: sembla que falta «{».
Context: ...rray<{value: string, label: string}>|[{ value: 'px', label: 'px' },{ value: '%', label: '%' }]` | 单位列表,可以通过选择器选择单位 ...

(UNPAIRED_BRACKETS)


[locale-violation] ~38-~38: Possible error ortogràfic. Aquesta forma verbal no es correspon amb la varietat seleccionada (central).
Context: ...oolean |false` ...

(EXIGEIX_VERBS_CENTRAL)

Additional comments not posted (7)
packages/configurator/docs/RadioGroupConfigurator.md (4)

3-5: LGTM!

The introduction is concise and clear.


7-9: LGTM!

The display section is straightforward and includes a relevant image.


11-23: LGTM!

The configuration example is correctly formatted and includes relevant properties.


26-31: Fix the unpaired symbol in the type row.

There is an unpaired symbol (') in the type row.

- | type     | `'radio' \| 'button'`                                                        | `'radio` | 单选组展示形式 |
+ | type     | `'radio' \| 'button'`                                                        | `'radio' | 单选组展示形式 |

Likely invalid or redundant comment.

Tools
LanguageTool

[typographical] ~31-~31: Unpaired symbol: ‘'’ seems to be missing
Context: ... | 'radio | 单选组展示形式 |

(EN_UNPAIRED_QUOTES)

packages/configurator/docs/NumberConfigurator.md (3)

3-5: LGTM!

The introduction is concise and clear.


7-9: LGTM!

The display section is straightforward and includes a relevant image.


11-23: LGTM!

The configuration example is correctly formatted and includes relevant properties.

@hexqi hexqi merged commit 1e856b7 into opentiny:refactor/develop Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants