-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stylePanel): fix setting border-radius could not work on first time #481
base: develop
Are you sure you want to change the base?
Conversation
@coderabbitai review |
Actions PerformedReview triggered.
|
WalkthroughThe changes in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/settings/styles/src/components/border/BorderGroup.vue (3 hunks)
Additional comments not posted (3)
packages/settings/styles/src/components/border/BorderGroup.vue (3)
293-293
: Initialization ofactivedBorder
state looks good.
337-343
: UpdatingborderRadius
properties using keys fromprops.style
ensures correct initial state reflection.
388-394
: The condition to prevent unnecessary updates when the value is 0 andprops.style[BORDER_RADIUS_PROPERTY.BorderRadius]
does not exist is a good safeguard.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
使用滑动条或者输入框设置 border-rarius,会发现第一次无法设置成功
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Refactor
Bug Fixes