Pass the axon external IP #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-ferreira
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Sorry for my ignorance but I'm not sure if I understood the implementation design.
My questions are basically around how is the axon.port will be referenced since you propose to delete the line of its instantiation on #82 and where the axon.external_ip is coming from.
ifrit98
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
LGTM! Will await confirmation from @p-ferreira before merging.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #82
This change allows a miner to pass an external IP for the axon to the chain.
This is useful for services like RunPod where the external IP check may not function correctly.