Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure mock reward model has new blacklist functions or crashes #76

Merged
merged 1 commit into from
Nov 20, 2023
Merged

ensure mock reward model has new blacklist functions or crashes #76

merged 1 commit into from
Nov 20, 2023

Conversation

ifrit98
Copy link
Contributor

@ifrit98 ifrit98 commented Nov 16, 2023

This is just so that when running a mock validator with --neuron.mock_reward_models the validator doesn't die.

p-ferreira
p-ferreira approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@p-ferreira p-ferreira left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's amazing, this was one item in my todo list, thank for you implementing that 🙏🏽

@p-ferreira p-ferreira merged commit 7709305 into staging Nov 20, 2023
4 checks passed
@p-ferreira p-ferreira mentioned this pull request Nov 20, 2023
Merged
@ifrit98
Copy link
Contributor Author

ifrit98 commented Nov 20, 2023

That's amazing, this was one item in my todo list, thank for you implementing that 🙏🏽

Of course! Ended up just running into it doing some sanity testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-ferreira p-ferreira p-ferreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ifrit98 @p-ferreira