Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/updated ci test #75

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Feature/updated ci test #75

merged 7 commits into from
Nov 20, 2023

Conversation

Eugene-hu
Copy link
Contributor

  • Updates CI tests to properly reflect version changes (Tested: Release/test/updated ci tests #73)
  • Removes changelog requirement for version updates
  • Also contain styling changes

@Eugene-hu Eugene-hu linked an issue Nov 15, 2023 that may be closed by this pull request
Version check in CI uses wrong version file path #72
Open
p-ferreira
p-ferreira approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@p-ferreira p-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So from what I understood we echo in our CI pipeline if the validator version was changed or not, is that correct?

@p-ferreira p-ferreira merged commit 151e2f1 into staging Nov 20, 2023
4 checks passed
@p-ferreira p-ferreira mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-ferreira p-ferreira p-ferreira approved these changes

@steffencruz steffencruz Awaiting requested review from steffencruz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version check in CI uses wrong version file path
2 participants
@Eugene-hu @p-ferreira