Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Penalty updates #62

Merged
merged 12 commits into from
Nov 9, 2023
Merged

Penalty updates #62

merged 12 commits into from
Nov 9, 2023

Conversation

p-ferreira
Copy link
Contributor

@p-ferreira p-ferreira commented Nov 7, 2023 •
edited

  • adds MatchContentCriteria
  • adds SimpleResponseLayoutCriteria
  • adds MatchLayoutCriteria
  • modifies following pruning at forward step
  • complement patterns in sentence match penalty function
  • adapt current flow to incorporate new criteria
  • adapt max penalties

steffencruz
steffencruz reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@steffencruz steffencruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MatchContentCriteria looks great. Looking forward to seeing MatchLayoutCriteria

prompting/validators/criteria.py Show resolved Hide resolved
prompting/validators/tasks.py Show resolved Hide resolved
steffencruz
steffencruz approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@steffencruz steffencruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-ferreira p-ferreira merged commit 9792fe1 into staging Nov 9, 2023
4 checks passed
@p-ferreira p-ferreira mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffencruz steffencruz steffencruz approved these changes

@isabella618033 isabella618033 Awaiting requested review from isabella618033

@bkb2135 bkb2135 Awaiting requested review from bkb2135

Assignees
No one assigned
Labels
2.1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p-ferreira @steffencruz