Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update line 54: wallet to wallet_ss58 #61

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

Jackalgirl
Copy link
Contributor

This will hopefully solve some issues where miners are not getting requests, as per cocofreddie's fix in the Opentensor Discord, here: https://discord.com/channels/799672011265015819/1161764867166961704/1169952256536354867

p-ferreira and others added 5 commits November 2, 2023 14:21
Copy link
Contributor

@Eugene-hu Eugene-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Jackalgirl , thanks for the changes. I can confirm that is a bug in the current text prompting.

However, we have strict rules on PRs for master branch, instead can I ask you to point your PR to the staging branch? We will include it in a upcoming release.

@Jackalgirl Jackalgirl changed the base branch from main to staging November 3, 2023 15:38
@Jackalgirl
Copy link
Contributor Author

hey @Jackalgirl , thanks for the changes. I can confirm that is a bug in the current text prompting.

However, we have strict rules on PRs for master branch, instead can I ask you to point your PR to the staging branch? We will include it in a upcoming release.

Thank you for pointing that out -- I'll make sure I do it correctly from here on out : )

Change made and re-review requested! (at least, I hope I did it right!)

@Eugene-hu
Copy link
Contributor

Thank you for pointing that out -- I'll make sure I do it correctly from here on out : )

Change made and re-review requested! (at least, I hope I did it right!)

Amazing, LGTM!

Copy link
Contributor

@ifrit98 ifrit98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ifrit98 ifrit98 changed the base branch from staging to main November 3, 2023 19:49
@ifrit98 ifrit98 changed the base branch from main to staging November 3, 2023 19:49
@ifrit98 ifrit98 merged commit db93595 into opentensor:staging Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants