Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock reward dedup #50

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Mock reward dedup #50

merged 5 commits into from
Oct 26, 2023

Conversation

ifrit98
Copy link
Contributor

@ifrit98 ifrit98 commented Oct 25, 2023 •
edited

Addresses duplication of MockRewardModel, was crashing validator when running with --neuron.mock_reward_models.

  • Removes reward.MockRewardModel in favor of mock.MockRewardModel
  • Consistent use of reward.MockRewardModel -> mock.MockRewardModel

@ifrit98 ifrit98 marked this pull request as draft October 26, 2023 00:14
@ifrit98 ifrit98 marked this pull request as ready for review October 26, 2023 13:04
p-ferreira
p-ferreira approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@p-ferreira p-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifrit98 ifrit98 mentioned this pull request Oct 26, 2023
Closed
@ifrit98 ifrit98 merged commit b6847d3 into staging Oct 26, 2023
4 checks passed
@p-ferreira p-ferreira mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-ferreira p-ferreira p-ferreira approved these changes

@Eugene-hu Eugene-hu Awaiting requested review from Eugene-hu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ifrit98 @p-ferreira @steffencruz