Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing from the "main" branch the doc to run subtensor locally #656

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

rajkaramchedu
Copy link
Contributor

@rajkaramchedu rajkaramchedu commented Jul 22, 2024

As per this Discord thread: https://discord.com/channels/799672011265015819/1260678915186495509

Docs issue: opentensor/developer-docs#221

Description

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@rajkaramchedu
Copy link
Contributor Author

For Documentation change, what should be the label? Right now it is failing the CI checks.

@rajkaramchedu rajkaramchedu added devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet labels Jul 22, 2024
@rajkaramchedu rajkaramchedu mentioned this pull request Jul 23, 2024
12 tasks
@sam0x17
Copy link
Contributor

sam0x17 commented Jul 23, 2024

For Documentation change, what should be the label? Right now it is failing the CI checks.

Once something else merges that bumps the spec version this should pass the finney deploy check. E2E tests are on the fritz for everyone at the moment so that is going to keep failing until that is fixed by someone. If this is time sensitive we should get @garrett-opentensor to force merge it

edit: I just merged in main and it will prob pass now

@sam0x17 sam0x17 requested a review from a team July 23, 2024 12:54
@sam0x17
Copy link
Contributor

sam0x17 commented Jul 23, 2024

I'll push a commit and see if I can get it merge-able real quick

@rajkaramchedu
Copy link
Contributor Author

For Documentation change, what should be the label? Right now it is failing the CI checks.

Once something else merges that bumps the spec version this should pass the finney deploy check. E2E tests are on the fritz for everyone at the moment so that is going to keep failing until that is fixed by someone. If this is time sensitive we should get @garrett-opentensor to force merge it

edit: I just merged in main and it will prob pass now

This and #657 are both valid. This is a little bit pressing, because I want to remove the doc from here asap. The #657 can wait. Perhaps @garrett-opentensor you can force merge this? Thanks! (Context: This is a part of consolidating subtensor node installation docs into docs.bittensor.com versions (to get to single source of truth for docs).

@garrett-opentensor garrett-opentensor merged commit c69bb7c into main Jul 23, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants