Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/total coldkey stake migration; clear map first #645

Merged

Conversation

camfairchild
Copy link
Contributor

Description

Fixes an issue with #636 where the TotalColdkeyStake map was not cleared before being set to the new values. So some keys retain an errant value of non-zero when they have no corresponding stake-map entry.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@distributedstatemachine distributedstatemachine added devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet labels Jul 16, 2024
@distributedstatemachine distributedstatemachine merged commit a2b8d70 into main Jul 16, 2024
17 of 19 checks passed
@distributedstatemachine distributedstatemachine deleted the fix/total-coldkey-stake-migration-clear-first branch July 16, 2024 23:27
@camfairchild camfairchild restored the fix/total-coldkey-stake-migration-clear-first branch July 18, 2024 20:49
@camfairchild camfairchild deleted the fix/total-coldkey-stake-migration-clear-first branch July 18, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants