-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/check metadata hash extension #637
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2d9e88
to
64aca95
Compare
This was referenced Jul 16, 2024
sam0x17
approved these changes
Jul 18, 2024
distributedstatemachine
approved these changes
Jul 18, 2024
13 tasks
orriin
approved these changes
Jul 19, 2024
open-junius
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades to polkadot-sdk
v1.10.0-rc2v1.10.0-rc3 which supportsframe_metadata_hash_extension::CheckMetadataHash
, required for Zondax's generic-substrate Ledger app.Related Issue(s)
Type of Change
Breaking Change
This PR introduces the Check Metadata Hash runtime extension which adds an extra
Mode
bit to all extrinsics.This indicates whether the chain node should verify the runtime hash provided in the extrinsic (used for secure signing). Therefore, this change breaks any current wallet clients that don't already support the extra bit (e.g. btcli).
New minimum PySubstrate version: https://github.com/polkascan/py-substrate-interface/releases/tag/v1.7.9
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyAdditional Notes
TODO: