Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/check metadata hash extension #637

Closed
wants to merge 13 commits into from

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Jul 15, 2024

Description

Upgrades to polkadot-sdk v1.10.0-rc2 v1.10.0-rc3 which supports frame_metadata_hash_extension::CheckMetadataHash, required for Zondax's generic-substrate Ledger app.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): requires new build flags for production (to generate metadata hash for wasm)

Breaking Change

This PR introduces the Check Metadata Hash runtime extension which adds an extra Mode bit to all extrinsics.
This indicates whether the chain node should verify the runtime hash provided in the extrinsic (used for secure signing). Therefore, this change breaks any current wallet clients that don't already support the extra bit (e.g. btcli).

New minimum PySubstrate version: https://github.com/polkascan/py-substrate-interface/releases/tag/v1.7.9

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

TODO:

  • Test integration with PolkadotJS, other wallets, etc.

@camfairchild camfairchild requested a review from orriin July 15, 2024 16:25
@camfairchild camfairchild marked this pull request as ready for review July 16, 2024 13:28
@sam0x17 sam0x17 requested a review from a team July 18, 2024 18:08
@sam0x17 sam0x17 requested a review from a team July 19, 2024 14:13
@unconst unconst closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Ledger support
6 participants