Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/hotkey swap #556

Merged
merged 24 commits into from
Jul 3, 2024
Merged

Refactor/hotkey swap #556

merged 24 commits into from
Jul 3, 2024

Conversation

distributedstatemachine
Copy link
Contributor

@distributedstatemachine distributedstatemachine commented Jun 21, 2024

Devnet companion: #567

Description

This PR :

refactors the hot key swap function to make it more testable
adds unit tests

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): refactor and testing

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

sam0x17
sam0x17 previously approved these changes Jun 21, 2024
pallets/subtensor/tests/registration.rs Show resolved Hide resolved
@sam0x17 sam0x17 requested a review from a team June 21, 2024 17:11
@sam0x17 sam0x17 added devnet-ready PR's companion has been merged into devnet-ready on-devnet PR has been deployed to devnet and removed devnet-ready PR's companion has been merged into devnet-ready labels Jun 24, 2024
@distributedstatemachine distributedstatemachine added devnet-pass PR has been tested on devnet on-testnet PR has been deployed to testnet testnet-pass PR was successfully tested on testnet and removed on-devnet PR has been deployed to devnet labels Jun 25, 2024
@distributedstatemachine distributedstatemachine added testnet-pass PR was successfully tested on testnet and removed testnet-pass PR was successfully tested on testnet on-testnet PR has been deployed to testnet labels Jul 3, 2024
@distributedstatemachine distributedstatemachine merged commit 1934f33 into main Jul 3, 2024
18 checks passed
@distributedstatemachine distributedstatemachine deleted the refactor/hotkey_swap branch July 3, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-pass PR has been tested on devnet testnet-pass PR was successfully tested on testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants