Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: liquid alpha #552

Merged
merged 20 commits into from
Jul 2, 2024
Merged

feat: liquid alpha #552

merged 20 commits into from
Jul 2, 2024

Conversation

distributedstatemachine
Copy link
Contributor

@distributedstatemachine distributedstatemachine commented Jun 20, 2024 •
edited
Loading

Description

This PR implements

  • Liquid Alpha feature.
  • moves the maths unit tests to the tests folder

Supercedes: #503

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@distributedstatemachine distributedstatemachine mentioned this pull request Jun 20, 2024
Closed
13 tasks
sam0x17
sam0x17 previously approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a few questions and potential tests that can be added that I have provided as commit suggestions for your convenience

pallets/subtensor/tests/math.rs Show resolved Hide resolved
pallets/subtensor/tests/math.rs Show resolved Hide resolved
pallets/subtensor/tests/math.rs Show resolved Hide resolved
pallets/subtensor/tests/math.rs Show resolved Hide resolved
@JohnReedV
unite alpha getters/setters & add extrinsic
d01cd1c 
Combines the getters and setters for alpha low/high

Removes alpha high/low hyperparams

adds an extrinsic to set alpha high/low

adds alpha values to subnetinfo
distributedstatemachine
distributedstatemachine commented Jun 21, 2024
View reviewed changes
pallets/subtensor/src/epoch.rs Outdated Show resolved Hide resolved
pallets/subtensor/src/epoch.rs Outdated Show resolved Hide resolved
@distributedstatemachine distributedstatemachine mentioned this pull request Jun 24, 2024
Merged
@distributedstatemachine distributedstatemachine added the devnet-ready PR's companion has been merged into devnet-ready label Jun 25, 2024
@sam0x17 sam0x17 added on-devnet PR has been deployed to devnet and removed devnet-ready PR's companion has been merged into devnet-ready labels Jun 25, 2024
@distributedstatemachine distributedstatemachine added the devnet-pass PR has been tested on devnet label Jun 25, 2024
@distributedstatemachine distributedstatemachine added the testnet-pass PR was successfully tested on testnet label Jul 2, 2024
@distributedstatemachine distributedstatemachine merged commit 8cb6cb1 into main Jul 2, 2024
13 checks passed
@distributedstatemachine distributedstatemachine deleted the feat/liquid_alpha_2 branch July 2, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mananitade Mananitade Mananitade left review comments

@sam0x17 sam0x17 sam0x17 approved these changes

@JohnReedV JohnReedV JohnReedV approved these changes

@open-junius open-junius open-junius approved these changes

@camfairchild camfairchild Awaiting requested review from camfairchild

@isabella618033 isabella618033 Awaiting requested review from isabella618033

@keithtensor keithtensor Awaiting requested review from keithtensor

@gztensor gztensor Awaiting requested review from gztensor

@orriin orriin Awaiting requested review from orriin

Assignees
No one assigned
Labels
devnet-pass PR has been tested on devnet on-devnet PR has been deployed to devnet testnet-pass PR was successfully tested on testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consensus Based Weights (Liquid Alpha)
5 participants
@distributedstatemachine @sam0x17 @JohnReedV @open-junius @Mananitade