reset neuron data on registration #522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@distributedstatemachine I don't think I'm doing any math operations |
|
Apologies @andreea-popescu-reef , i meant unsafe , or potentially panicing operation. @keithtensor can you take a look ? the CI should catch these |
andreea-popescu-reef
force-pushed
the
fix-reg
branch
from
56a0328
to
4e4af9d
Compare
distributedstatemachine
requested review from
sam0x17,
camfairchild,
JohnReedV,
distributedstatemachine,
keithtensor,
open-junius and
a team
orriin
reviewed
Jun 24, 2024
pallets/subtensor/src/uids.rs
Outdated
| @@ -9,6 +9,22 @@ impl<T: Config> Pallet<T> { | |||
| SubnetworkN::<T>::get(netuid) | |||
| } | |||
|
|
|||
| pub fn set_emission_for_uid(netuid: u16, neuron_uid: u16, emission: u64) { | |||
| Emission::<T>::mutate(netuid, |v| v[neuron_uid as usize] = emission); | |||
There was a problem hiding this comment.
Could this direct indexing panic? cc @keithtensor
orriin
reviewed
Jun 24, 2024
andreea-popescu-reef
force-pushed
the
fix-reg
branch
from
4e4af9d
to
85895a4
Compare
andreea-popescu-reef
force-pushed
the
fix-reg
branch
from
85895a4
to
44ce566
Compare
sam0x17
reviewed
Jun 25, 2024
sam0x17
approved these changes
Jun 25, 2024
open-junius
reviewed
Jun 28, 2024
pallets/subtensor/src/uids.rs
Outdated
| @@ -9,6 +9,15 @@ impl<T: Config> Pallet<T> { | |||
| SubnetworkN::<T>::get(netuid) | |||
| } | |||
|
|
|||
| /// Resets the trust, emission, consensus, incentive, dividends of the neuron to default | |||
| pub fn clear_neuron(netuid: u16, neuron_uid: u16) { | |||
| Emission::<T>::mutate(netuid, |v| v[neuron_uid as usize] = 0); | |||
There was a problem hiding this comment.
can you add the length check before index with neuron_uid.
andreea-popescu-reef
force-pushed
the
fix-reg
branch
from
232f687
to
51fc171
Compare
| @@ -9,6 +9,26 @@ impl<T: Config> Pallet<T> { | |||
| SubnetworkN::<T>::get(netuid) | |||
| } | |||
|
|
|||
| fn clear_element_at<N>(position: u16) -> impl Fn(&mut Vec<N>) | |||
There was a problem hiding this comment.
We are almost there! can you please add doc comments to this , as it would break some lints down the line.
I will get this approved today , and move it through our deployment process. I estimate this change would be on testnet in about 2 weeks
There was a problem hiding this comment.
right, added.
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On neuron registration the trust, emission, consensus, incentive, dividends values as well as axon info associated with the assigned neuron_uid are inherited from the previous neuron. Thus for the first few blocks after registration these values will be wrong, then reset to zero and then get populated with the correct values for the newly registered neuron. This change resets these values on neuron registration.
Related Issue(s)
N/A
Type of Change
Breaking Change
no
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
N/A
Additional Notes
N/A