Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/docker #496

Merged
merged 3 commits into from
May 31, 2024
Merged

Hotfix/docker #496

merged 3 commits into from
May 31, 2024

Conversation

distributedstatemachine
Copy link
Contributor

@distributedstatemachine distributedstatemachine commented May 30, 2024

Description

This PR

  • removes references to --ws-* from the docker compose file
  • changes the repo from docker to this repo in the compose file
  • adds a ci to build an image when a new tag is published , and commits to main.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@distributedstatemachine distributedstatemachine requested a review from a team May 30, 2024 19:13
@distributedstatemachine distributedstatemachine added devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet labels May 30, 2024
sam0x17
sam0x17 previously approved these changes May 30, 2024
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

.github/workflows/docker.yml Outdated Show resolved Hide resolved
Co-authored-by: Sam Johnson <sam@durosoft.com>
Copy link
Contributor

@gztensor gztensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works locally

Copy link
Contributor

@open-junius open-junius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@distributedstatemachine distributedstatemachine merged commit cbd42df into main May 31, 2024
9 checks passed
@distributedstatemachine distributedstatemachine deleted the hotfix/docker branch May 31, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants