Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Senate membership changes #490

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented May 29, 2024

Devnet companion: #557

Description

See related issue. This PR fixes a bug where current root members cannot become a Senate member after attaining the requirements after registering on the root network, initially.

This PR adds the call subtensorModule.adjust_senate(hotkey) to attempt to join the Senate when eligible.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

TODO

  • Benchmarking weights

Breaking Change

NA

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

NA

Additional Notes

An alternative solution is to call join_senate_if_eligible during a root_register call if the hotkey is already registered

@camfairchild camfairchild marked this pull request as ready for review June 14, 2024 04:10
@camfairchild camfairchild mentioned this pull request Jun 14, 2024
13 tasks
@sam0x17 sam0x17 requested a review from a team June 19, 2024 14:22
sam0x17
sam0x17 previously approved these changes Jun 19, 2024
@sam0x17 sam0x17 requested review from a team, keithtensor and open-junius June 19, 2024 15:35
@sam0x17 sam0x17 added the devnet-ready PR's companion has been merged into devnet-ready label Jun 21, 2024
@sam0x17 sam0x17 added red team feature development, etc on-devnet PR has been deployed to devnet and removed devnet-ready PR's companion has been merged into devnet-ready labels Jun 21, 2024
@distributedstatemachine distributedstatemachine added the devnet-pass PR has been tested on devnet label Jun 25, 2024
@distributedstatemachine distributedstatemachine added testnet-pass PR was successfully tested on testnet and removed on-devnet PR has been deployed to devnet labels Jul 2, 2024
@sam0x17
Copy link
Contributor

sam0x17 commented Jul 3, 2024

clippy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-pass PR has been tested on devnet red team feature development, etc testnet-pass PR was successfully tested on testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Senate Membership
4 participants