Remove more direct indexing #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithtensor
commented
May 16, 2024
| let hotkey_pubkey: MultiAddress<T::AccountId, ()> = MultiAddress::Id(hotkey.clone()); | ||
| let binding = hotkey_pubkey.encode(); | ||
| // Skip extra 0th byte. | ||
| let hotkey_bytes: &[u8] = binding[1..].as_ref(); |
There was a problem hiding this comment.
This one I'm fairly certain but not 100% sure -- it's actually trying to skip the discriminant byte from the MultiAddress enum, right? If so, we can just encode the hotkey directly, as I've done in my PR.
There was a problem hiding this comment.
This seems right to me
distributedstatemachine
approved these changes
May 16, 2024
sam0x17
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes more cases of direct indexing.