Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/gov/subnet owners #425

Draft
wants to merge 4 commits into
base: development
Choose a base branch
from
Draft

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented May 16, 2024

Description

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

This change impacts the voting process for the Senate. Instead of using the subtensorModule.vote(...) call (now removed), Senate members should use governance.vote(..., group: Senate, ...)

This change also renames the Triumvirate (collective) pallet to Governance, which impacts calls.

TODO

  • New SubnetOwners governance group
    • Add group
    • Auto-manage membership
    • Allow group to vote
  • Custom origin for 'Council' including multiple groups
  • Rename the collective pallet to governance
    • Write migration
    • change calls throughout runtime
  • Allow voting from the collective pallet instead of subtensorModule
  • Allow configurable (runtime upgrade) voting thresholds for each group
  • Add tests

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Governance
2 participants