Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: clippy deny warnings #398

Merged
merged 7 commits into from
May 8, 2024
Merged

ci: clippy deny warnings #398

merged 7 commits into from
May 8, 2024

Conversation

orriin
Copy link
Contributor

@orriin orriin commented May 6, 2024 •
edited by sam0x17
Loading

  • Makes clippy warnings fail by passing --deny warnings
  • Runs clippy twice, once with features once without

@orriin orriin added the blue team defensive programming, CI, etc label May 6, 2024
@sam0x17
Copy link
Contributor

sam0x17 commented May 6, 2024

looks like some clippys need fixing with that change now @orriin

sam0x17
sam0x17 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me once CI is passing

@orriin orriin force-pushed the fix/clippy-deny-warnings branch from 3c079e8 to 649e0db Compare May 6, 2024 17:13
@orriin orriin force-pushed the fix/clippy-deny-warnings branch from 649e0db to 3465d33 Compare May 6, 2024 17:23
@orriin orriin merged commit d7633ac into development May 8, 2024
8 checks passed
@orriin orriin deleted the fix/clippy-deny-warnings branch May 8, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@distributedstatemachine distributedstatemachine Awaiting requested review from distributedstatemachine

@keithtensor keithtensor Awaiting requested review from keithtensor

Assignees

@orriin orriin

Labels
blue team defensive programming, CI, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orriin @sam0x17