Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the metadata #391

Merged
merged 10 commits into from
May 6, 2024
Merged

Fix the metadata #391

merged 10 commits into from
May 6, 2024

Conversation

open-junius
Copy link
Contributor

@open-junius open-junius commented May 3, 2024

Description

The pr fixed the metadata via write the comments in correct way. It adds an unit test in runtime to verify.

Related Issue(s)

  • Closes #[384]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

part of #384

@open-junius open-junius self-assigned this May 3, 2024
@open-junius open-junius added documentation Improvements or additions to documentation in progress blue team defensive programming, CI, etc labels May 3, 2024
runtime/tests/pallet_proxy.rs Outdated Show resolved Hide resolved
runtime/tests/pallet_proxy.rs Outdated Show resolved Hide resolved
@open-junius open-junius marked this pull request as draft May 4, 2024 06:33
@open-junius open-junius marked this pull request as ready for review May 6, 2024 06:12
@open-junius open-junius removed documentation Improvements or additions to documentation in progress labels May 6, 2024
Copy link
Contributor

@orriin orriin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@open-junius open-junius merged commit 2cc70b3 into development May 6, 2024
7 checks passed
@open-junius open-junius deleted the junius/fix-metadata branch May 6, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blue team defensive programming, CI, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants