Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: allow unstake below the min nom threshold when unstaking entire stake #382

Merged
merged 2 commits into from
Apr 30, 2024
Merged

hotfix: allow unstake below the min nom threshold when unstaking entire stake #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
849fad7
fix: allow unstaking entire balance
orriin Apr 30, 2024
562a0fa
fix: bump spec version
orriin Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion pallets/subtensor/src/staking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use super::*;
use frame_support::storage::IterableStorageDoubleMap;
use sp_runtime::traits::Zero;

impl<T: Config> Pallet<T> {
// ---- The implementation for the extrinsic become_delegate: signals that this hotkey allows delegated stake.
Expand Down Expand Up @@ -305,7 +306,8 @@ impl<T: Config> Pallet<T> {
Stake::<T>::get(&hotkey, &coldkey).saturating_sub(stake_to_be_removed);

ensure!(
total_stake_after_remove >= NominatorMinRequiredStake::<T>::get(),
total_stake_after_remove.is_zero()
|| total_stake_after_remove >= NominatorMinRequiredStake::<T>::get(),
Error::<T>::NomStakeBelowMinimumThreshold
);
}
Expand Down
7 changes: 7 additions & 0 deletions pallets/subtensor/tests/staking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2695,5 +2695,12 @@ fn test_remove_stake_below_minimum_threshold() {
),
Error::<Test>::NomStakeBelowMinimumThreshold
);

// Nomination stake can still remove their entire stake
assert_ok!(SubtensorModule::remove_stake(
<<Test as Config>::RuntimeOrigin>::signed(coldkey2),
hotkey1,
initial_stake
));
})
}
2 changes: 1 addition & 1 deletion runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
// `spec_version`, and `authoring_version` are the same between Wasm and native.
// This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
// the compatible custom types.
spec_version: 147,
spec_version: 148,
impl_version: 1,
apis: RUNTIME_API_VERSIONS,
transaction_version: 1,
Expand Down