Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old script arguments --ws-external and --ws-max-connections #364

Merged

Conversation

PawKanarek
Copy link
Contributor

@PawKanarek PawKanarek commented Apr 24, 2024

Description

When you run the script ./scripts/run/subtensor.sh on the newest version, it throws the error

error: unexpected argument '--ws-external' found                                                                                                                
                                                                                                                                                                
  tip: a similar argument exists: '--rpc-external'                                                                                                              

This PR updates the parameters of the script according to info from PR #324

Related Issue(s)

PR #324

Type of Change

Removed deprecated parameter --ws-external. Changed --ws-max-connections -> --rpc-max-connections

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@distributedstatemachine distributedstatemachine merged commit 42ff4c9 into opentensor:development May 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants