Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test for per-subnet take emission #356

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

gztensor
Copy link
Contributor

Description

Update the test_different_subnet_take_different_distribution test so that it accounts for dynamic emission

Related Issue(s)

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): Tests

Breaking Change

n/a

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pallets/subtensor/tests/staking.rs Outdated Show resolved Hide resolved
pallets/subtensor/tests/staking.rs Outdated Show resolved Hide resolved
@@ -3205,6 +3205,14 @@ fn test_can_set_different_take_per_subnet() {
});
}

fn assert_substake(coldkey: &U256, hotkey: &U256, netuid: u16, amount: u64) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over better still , we should move it to mocks

@distributedstatemachine distributedstatemachine merged commit 44caaa9 into dynamic Apr 26, 2024
@distributedstatemachine distributedstatemachine deleted the test/test_dtao_emission branch April 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants