Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new development/deployment/release process #346

Merged
merged 54 commits into from
May 28, 2024
Merged

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Apr 21, 2024

Fixes #344

note that this merges into main because that is what determines the root CI settings for the repo once we change default branch back to main. May need to backport as well if there are still lingering branches on the day this is merged, but the idea of this PR is that once it is merged, all new PRs target main, so we shouldn't need to

will want to merge on the same day @garrett-opentensor makes the proper changes to the repo/branch protection settings, which are outlined in detail in the "branches" section of CONTRIBUTING.md

@sam0x17 sam0x17 self-assigned this Apr 21, 2024
@sam0x17 sam0x17 added devnet-pass PR has been tested on devnet testnet-pass PR was successfully tested on testnet and removed devnet-pass PR has been tested on devnet testnet-pass PR was successfully tested on testnet labels Apr 21, 2024
@sam0x17 sam0x17 changed the title Sam revamp deployment new deployment process Apr 22, 2024
@sam0x17 sam0x17 added breaking-change This PR introduces a noteworthy breaking change devnet-pass PR has been tested on devnet on-devnet PR has been deployed to devnet on-testnet PR has been deployed to testnet testnet-pass PR was successfully tested on testnet and removed breaking-change This PR introduces a noteworthy breaking change labels Apr 26, 2024
Copy link

@opentensor/cerebrum breaking change detected! Please prepare accordingly!

@sam0x17 sam0x17 changed the base branch from development to main May 10, 2024 07:11
@sam0x17 sam0x17 marked this pull request as ready for review May 10, 2024 07:11
@sam0x17 sam0x17 removed devnet-pass PR has been tested on devnet on-devnet PR has been deployed to devnet on-testnet PR has been deployed to testnet labels May 10, 2024
@sam0x17 sam0x17 added devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet and removed hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet labels May 23, 2024
@sam0x17 sam0x17 changed the title new deployment process new development/deployment/release process May 23, 2024
@sam0x17 sam0x17 requested a review from a team May 23, 2024 18:29
@sam0x17
Copy link
Contributor Author

sam0x17 commented May 23, 2024

note: should probably add a PR template for the companion PRs 🤔

issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: '@opentensor/cerebrum / @opentensor/gyrus / @opentensor/cortex breaking change detected! Please prepare accordingly!'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we resolved permissioning issues with these alerts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt it, @garrett-opentensor will need to make sure each of those groups has permissions to receive notifications in github

CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/workflows/testnet-labels.yml Show resolved Hide resolved
@sam0x17 sam0x17 merged commit 686e6fb into main May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new release process / CI actions / checks
5 participants