generated from substrate-developer-hub/substrate-node-template
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_root_weights() #335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distributedstatemachine
requested changes
Apr 28, 2024
JohnReedV
added
the
breaking-change
This PR introduces a noteworthy breaking change
label
Apr 30, 2024
sam0x17
approved these changes
Apr 30, 2024
// * 'MaxWeightExceeded': | ||
// - Attempting to set weights with max value exceeding limit. | ||
// | ||
#[pallet::call_index(8)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we haven't really started doing this yet but ideally these should be doc comments
TODO:
|
distributedstatemachine
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new function
set_root_weights()
for setting root weights with the coldkey.Changes
set_root_weights
which contains the original logic associated with the root network fromset_weights
.set_weights
now rejects calls for the root network.set_weights
have been removed.Related Issue(s)
N/A
Type of Change
Breaking Change
Calls to
set_weights
for the root network will now be rejected. Instead they should callset_root_weights
.Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.