Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_root_weights() #335

Merged
merged 9 commits into from
May 5, 2024
Merged

Add set_root_weights() #335

merged 9 commits into from
May 5, 2024

Conversation

JohnReedV
Copy link
Contributor

@JohnReedV JohnReedV commented Apr 16, 2024

Description

This PR implements a new function set_root_weights() for setting root weights with the coldkey.

Changes

  • Created set_root_weights which contains the original logic associated with the root network from set_weights.
  • set_weights now rejects calls for the root network.
  • Root specific operations in set_weights have been removed.
  • Added & updated associated unit tests.

Related Issue(s)

N/A

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

Calls to set_weights for the root network will now be rejected. Instead they should call set_root_weights.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@JohnReedV JohnReedV marked this pull request as ready for review April 17, 2024 15:12
@JohnReedV JohnReedV self-assigned this Apr 25, 2024
@JohnReedV JohnReedV added the breaking-change This PR introduces a noteworthy breaking change label Apr 30, 2024
// * 'MaxWeightExceeded':
// - Attempting to set weights with max value exceeding limit.
//
#[pallet::call_index(8)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we haven't really started doing this yet but ideally these should be doc comments

@distributedstatemachine
Copy link
Contributor

distributedstatemachine commented May 1, 2024

TODO:

  • This release has to be coordinated with @opentensor/cortex cc @sam0x17

@sam0x17 sam0x17 merged commit 181a99c into development May 5, 2024
7 checks passed
@sam0x17 sam0x17 deleted the set_root_weights_coldkey branch May 5, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This PR introduces a noteworthy breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants