Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(docker): Use raw_testspec for test nodes #329

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

birkskyum
Copy link

See #325

@birkskyum birkskyum changed the title Set test chain file conditionally based on network Use raw_testspec for test nodes Apr 15, 2024
Copy link
Contributor

@open-junius open-junius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@birkskyum
Copy link
Author

birkskyum commented Apr 27, 2024

@open-junius , anything holding this?

After this PR it would be great if someone could also have a look at the --ws and --rpc flags if they are all correct, because it seems there have been some changes lately removing some of the --ws flags in favor of --rpc

@open-junius
Copy link
Contributor

open-junius commented Apr 29, 2024

@open-junius , anything holding this?

After this PR it would be great if someone could also have a look at the --ws and --rpc flags if they are all correct, because it seems there have been some changes lately removing some of the --ws flags in favor of --rpc

You are right, we need remove the --ws after upgraded to polkadot 1.0. And other like --ws-max-connections

@birkskyum
Copy link
Author

@open-junius , would you like me to apply that to this pr, or can it be done after?

@open-junius
Copy link
Contributor

@open-junius , would you like me to apply that to this pr, or can it be done after?

We can do it after upgrade the master branch to polkadot 1.0. the doc is for master. You can create new one after upgrade, and thanks for you update and verify the doc

@birkskyum birkskyum mentioned this pull request May 31, 2024
3 tasks
@birkskyum birkskyum changed the title Use raw_testspec for test nodes hotfix/docker Use raw_testspec for test nodes Jun 2, 2024
@birkskyum birkskyum changed the title hotfix/docker Use raw_testspec for test nodes hotfix(docker): Use raw_testspec for test nodes Jun 2, 2024
@birkskyum
Copy link
Author

birkskyum commented Jun 2, 2024

@open-junius Is the master on polkadot 1 now, or where can it be tracked? I know the testchain is on v1, and this is a testchain-only fix

@birkskyum
Copy link
Author

anything holding this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants