Emission schedule #290
Merged
Emission schedule #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
approved these changes
Mar 29, 2024
pallets/subtensor/tests/root.rs
Outdated
Comment on lines
764
to
790
| let total_supply: u64 = pallet_subtensor::TotalSupply::<Test>::get(); | ||
| let original_emission: u64 = pallet_subtensor::DefaultBlockEmission::<Test>::get(); | ||
| let halving_issuance: u64 = total_supply / 2; | ||
| let mut step: usize = original_emission as usize; | ||
|
|
||
| for issuance in (0..=total_supply).step_by(step) { | ||
| SubtensorModule::set_total_issuance(issuance); | ||
|
|
||
| let issuance_f64 = issuance as f64; | ||
| let h = f64::log2(1.0 / (1.0 - issuance_f64 / (2.0 * halving_issuance as f64))); | ||
| let h = h.floor(); | ||
| let emission_percentage = f64::powf(2.0, -h); | ||
|
|
||
| let expected_emission: u64 = if issuance < total_supply { | ||
| (original_emission as f64 * emission_percentage) as u64 | ||
| } else { | ||
| 0 | ||
| }; | ||
| assert_eq!( | ||
| SubtensorModule::get_block_emission(), | ||
| expected_emission, | ||
| "Issuance: {}", | ||
| issuance_f64 | ||
| ); | ||
| step = expected_emission as usize; | ||
| } | ||
| }); |
There was a problem hiding this comment.
I guess as long as this consistently passes this is fine but I suppose if there is ever a hardware difference w.r.t floating points vs the safe implementation this test might fail on some random hardware. Probably fine tho
my preference tho would be that this uses safe math as well if possible
sam0x17
requested changes
Mar 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.