feat: add identity pallet to the runtime #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe that the community will like this feature |
camfairchild
requested changes
Aug 16, 2023
| @@ -553,6 +559,30 @@ impl pallet_preimage::Config for Runtime { | |||
| type ByteDeposit = PreimageByteDeposit; | |||
| } | |||
|
|
|||
| parameter_types! { | |||
| pub const BasicDeposit: Balance = (1) as Balance * 2_000 * 10_000_000 + (258 as Balance) * 100 * 1_000_000; | |||
There was a problem hiding this comment.
Why is the calculation like this? Is there some documentation that can be added?
There was a problem hiding this comment.
This is from the polkadot runtime.
https://github.com/paritytech/polkadot/blob/d74c60b6489f31f437edb1a19de0d0f6b8ad432e/runtime/polkadot/src/lib.rs#L620
Comment on lines
+564
to
+566
| pub const FieldDeposit: Balance = (0) as Balance * 2_000 * 10_000_000 + (66 as Balance) * 100 * 1_000_000; | ||
| pub const SubAccountDeposit: Balance = (1) as Balance * 2_000 * 10_000_000 + (53 as Balance) * 100 * 1_000_000; | ||
| pub const MaxSubAccounts: u32 = 100; |
There was a problem hiding this comment.
Comment on lines
+581
to
+582
| type ForceOrigin = MoreThanHalfCouncil; | ||
| type RegistrarOrigin = MoreThanHalfCouncil; |
There was a problem hiding this comment.
So then (currently) adding a registrar is a 2 of 3 from the triumvirate?
Wonder if using the Validator set makes more sense? Or perhaps an additional council group can be formed.
There was a problem hiding this comment.
this should be a team decision, i believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.