Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to polkadot-v0.9.40 #151

Closed
wants to merge 3 commits into from

Conversation

cuteolaf
Copy link
Contributor

@cuteolaf cuteolaf commented Jun 7, 2023

  • Upgrade dependencies

@cuteolaf
Copy link
Contributor Author

cuteolaf commented Jun 7, 2023

@S0AndS0 @Rubberbandits @shibshib @eduardogr
A quick question: How long does it usually take to generate weights for subtensor pallet?
Based on my understanding of the benchmarking scripts, I assume quite a long time for benchmarking set_weight

@Rubberbandits
Copy link
Contributor

@S0AndS0 @Rubberbandits @shibshib @eduardogr A quick question: How long does it usually take to generate weights for subtensor pallet? Based on my understanding of the benchmarking scripts, I assume quite a long time for benchmarking set_weight

I switched set_weight benchmarking to burned registration from PoW, which significantly speeds up benchmarking. Only takes about a minute now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config for GRANDPA finality gadget seems wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know what the issue is and feel free to correct it.

@cuteolaf
Copy link
Contributor Author

cuteolaf commented Jun 8, 2023

@S0AndS0 @Rubberbandits @shibshib @eduardogr A quick question: How long does it usually take to generate weights for subtensor pallet? Based on my understanding of the benchmarking scripts, I assume quite a long time for benchmarking set_weight

I switched set_weight benchmarking to burned registration from PoW, which significantly speeds up benchmarking. Only takes about a minute now.

one minute for generating all the weights?

@Rubberbandits
Copy link
Contributor

@S0AndS0 @Rubberbandits @shibshib @eduardogr A quick question: How long does it usually take to generate weights for subtensor pallet? Based on my understanding of the benchmarking scripts, I assume quite a long time for benchmarking set_weight

I switched set_weight benchmarking to burned registration from PoW, which significantly speeds up benchmarking. Only takes about a minute now.

one minute for generating all the weights?

That's correct, though I cant remember if its merged into main yet.

@cuteolaf
Copy link
Contributor Author

cuteolaf commented Jun 8, 2023

seems like it's not merged into main yet.

@cuteolaf
Copy link
Contributor Author

cuteolaf commented Jun 8, 2023

which branch is it? I'd like to cherry-pick the necessary commits.

@Rubberbandits
Copy link
Contributor

which branch is it? I'd like to cherry-pick the necessary commits.

https://github.com/opentensor/subtensor/blob/eaa2c82e39f3dd5084143599788d6bf4d3cccbb7/pallets/subtensor/src/benchmarks.rs

It's apart of the sudo decentralization PR, which is waiting for python CLI to be complete as the chain side is finished (barring some APIs i have to expose for proposal data)

@cuteolaf cuteolaf marked this pull request as ready for review July 8, 2023 14:09
@cuteolaf cuteolaf marked this pull request as draft July 31, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants